fix: Big int handling #1758
fix: Big int handling #1758
Conversation
|
pkg.pr.new packages benchmark commit |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes big integer handling for floating-point literals in the TGSL type system. The fix ensures that very large numeric literals (beyond 2^63) are treated as abstract floats rather than integers, eliminating the need for explicit f32 casts.
- Added a check in
numericLiteralToSnippetto handle values exceeding 2^63 as abstract floats - Removed unnecessary f32 casts from floating-point constants like
FLT_MAX
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typegpu/src/tgsl/generationHelpers.ts | Added logic to treat large numeric literals as abstract floats |
| packages/typegpu-color/src/oklab.ts | Removed unnecessary f32 cast from FLT_MAX constant |
| packages/typegpu/tests/examples/individual/oklab.test.ts | Updated test expectation to match new FLT_MAX format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
| } | ||
|
|
||
| export function numericLiteralToSnippet(value: number): Snippet { | ||
| if (Math.abs(value) > 2 ** 63) { |
There was a problem hiding this comment.
are you sure about
There was a problem hiding this comment.
Sorry, my bad
There was a problem hiding this comment.
How about value >= 2 ** 63 || value < -(2 ** 63)?
There was a problem hiding this comment.
oh yea, forgot that we take Math.abs
|
According to your question, I believe if we take |
2 participants
Numbers exceeding 2**63 are now automatically inferred as abstractFloat, since it could not fit in an abstractInt anyway.
Now the following does not warn, and the cast is unnecessary.
const FLT_MAX = f32(3.40282346e38);You could argue that we should cast all numbers exceeding safe integers (~2**53) to floats, and that might be correct. Can you help me decide?